lkml.org 
[lkml]   [2016]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 6/7] perf config: Remove needless code about config set at cmd_config()
Em Tue, May 31, 2016 at 01:44:10AM +0900, Taeung Song escreveu:
> show_config() was reimplemented using perf_config()
> so it isn't needed to use perf_config_set__new() at cmd_config().
> And perf_config_set__delete() isn't needed at cmd_config() because of
> calling the function at run_builtin() when a sub-command finished.
>
> And it isn't also needed to declare 'config_set' as extern variable
> because the variable is only handled at util/config.c from now on.

But the existing code looks more natural, i.e. before dealing with the
config_set, we try instantiating it, handling errors at constructor
calling time, etc.

Then, finally, calling the destructor when we don't need it anymore.

> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
> Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
> ---
> tools/perf/builtin-config.c | 8 --------
> tools/perf/util/config.h | 2 --
> 2 files changed, 10 deletions(-)
>
> diff --git a/tools/perf/builtin-config.c b/tools/perf/builtin-config.c
> index cf6c396..412c725 100644
> --- a/tools/perf/builtin-config.c
> +++ b/tools/perf/builtin-config.c
> @@ -64,12 +64,6 @@ int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
> else if (use_user_config)
> config_exclusive_filename = user_config;
>
> - config_set = perf_config_set__new();
> - if (!config_set) {
> - ret = -1;
> - goto out_err;
> - }
> -
> switch (actions) {
> case ACTION_LIST:
> if (argc) {
> @@ -90,7 +84,5 @@ int cmd_config(int argc, const char **argv, const char *prefix __maybe_unused)
> usage_with_options(config_usage, config_options);
> }
>
> - perf_config_set__delete();
> -out_err:
> return ret;
> }
> diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h
> index e9b47b3..be4e603 100644
> --- a/tools/perf/util/config.h
> +++ b/tools/perf/util/config.h
> @@ -20,8 +20,6 @@ struct perf_config_set {
> struct list_head sections;
> };
>
> -extern struct perf_config_set *config_set;
> -
> struct perf_config_set *perf_config_set__new(void);
> void perf_config_set__delete(void);
>
> --
> 2.5.0

\
 
 \ /
  Last update: 2016-05-30 22:01    [W:0.502 / U:1.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site