Messages in this thread Patch in this message | | | Date | Mon, 30 May 2016 19:56:16 +0100 | From | Mel Gorman <> | Subject | Re: BUG: scheduling while atomic: cron/668/0x10c9a0c0 (was: Re: mm, page_alloc: avoid looking up the first zone in a zonelist twice) |
| |
On Mon, May 30, 2016 at 07:37:39PM +0200, Geert Uytterhoeven wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index dba8cfd0b2d6..f2c1e47adc11 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -3232,6 +3232,9 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > > * allocations are system rather than user orientated > > */ > > ac->zonelist = node_zonelist(numa_node_id(), gfp_mask); > > + ac->preferred_zoneref = first_zones_zonelist(ac->zonelist, > > + ac->high_zoneidx, ac->nodemask); > > + ac->classzone_idx = zonelist_zone_idx(ac->preferred_zoneref); > > page = get_page_from_freelist(gfp_mask, order, > > ALLOC_NO_WATERMARKS, ac); > > if (page) > > Thanks, but unfortunately it doesn't help. >
Thanks. Please try the following instead
diff --git a/mm/page_alloc.c b/mm/page_alloc.c index bb320cde4d6d..557549c81083 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3024,6 +3024,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, apply_fair = false; fair_skipped = false; reset_alloc_batches(ac->preferred_zoneref->zone); + z = ac->preferred_zoneref; goto zonelist_scan; } -- Mel Gorman SUSE Labs
| |