Messages in this thread Patch in this message | | | From | Matt Fleming <> | Subject | [PATCH] sched/fair: Update rq clock before updating nohz cpu load | Date | Tue, 3 May 2016 20:46:54 +0100 |
| |
If we're accessing rq_clock() (e.g. in sched_avg_update()) we should update the rq clock before calling cpu_load_update(), otherwise any time calculations will be stale.
All other paths currently call update_rq_clock().
Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Mike Galbraith <umgwanakikbuti@gmail.com> Cc: Mel Gorman <mgorman@techsingularity.net> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Rik van Riel <riel@redhat.com> Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk> --- kernel/sched/fair.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index b8a33abce650..aa9ba82f0d7c 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -4723,6 +4723,7 @@ void cpu_load_update_nohz_stop(void) load = weighted_cpuload(cpu_of(this_rq)); raw_spin_lock(&this_rq->lock); + update_rq_clock(this_rq); cpu_load_update_nohz(this_rq, curr_jiffies, load); raw_spin_unlock(&this_rq->lock); } -- 2.7.3
| |