lkml.org 
[lkml]   [2016]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive
Date
> From: Yongji Xie [mailto:xyjxie@linux.vnet.ibm.com]
> Sent: Tuesday, May 03, 2016 1:52 PM
>
> >> +
> >> + if (!(res->start & ~PAGE_MASK)) {
> >> + /*
> >> + * Add shadow resource for sub-page bar whose mmio
> >> + * page is exclusive in case that hot-add device's
> >> + * bar is assigned into the mem hole.
> >> + */
> >> + shadow_res = kzalloc(sizeof(*shadow_res), GFP_KERNEL);
> >> + shadow_res->resource.start = res->end + 1;
> >> + shadow_res->resource.end = res->start + PAGE_SIZE - 1;
> > What about res->start not page aligned so you end up still having
> > a portion before res->start not exclusively reserved?
>
> Do you mean add a 'dummy' resource to reserve the portion
> before res->start if res->start not page aligned?
>
> But would it happen that there is a mem hole in the portion
> before res->start? The resource should have been assigned
> into the hole at the beginning.
>

Just a quick thought. Another device might occupy that range
before initializing this device, and then 'another device' is hot
removed later...

Thanks
Kevin
\
 
 \ /
  Last update: 2016-05-03 08:21    [W:0.455 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site