lkml.org 
[lkml]   [2016]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] efivarfs: merge boolean flag arguments
On Thu, 21 Apr, at 03:24:29PM, Julia Lawall wrote:
> The parameters atomic and duplicates of efivar_init always have opposite
> values. Drop the parameter atomic, replace the uses of !atomic with
> duplicates, and update the call sites accordingly.
>
> The code using duplicates is slightly reorganized with an else, to avoid
> duplicating the lock code.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Not tested. I have assumed that the calls to both variable_is_present and
> dup_variable_bug need to be out of the lock.
>
> drivers/firmware/efi/efivars.c | 5 ++---
> drivers/firmware/efi/vars.c | 23 ++++++++++-------------
> fs/efivarfs/super.c | 3 +--
> include/linux/efi.h | 3 +--
> 4 files changed, 14 insertions(+), 20 deletions(-)

Applied. Thanks Julia.

\
 
 \ /
  Last update: 2016-05-03 18:01    [W:0.145 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site