lkml.org 
[lkml]   [2016]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node
On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote:
> This patch changes the compatible of Tegra132 fuse node
> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
> Tegra132, the fuse driver can't find the corresponding node.

Okay, that's not really a good reason to modify the DTS. What we should
do instead is make sure that the OF table contains the entry on Tegra132
builds. Unless the IP block really is different and Tegra124 and
Tegra132 aren't compatible in this regard after all.

In the latter case the commit message should reflect the real reason.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-05-03 18:01    [W:5.582 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site