lkml.org 
[lkml]   [2016]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] musb_host: fix lockup on rxcsr_h_error
Hi,

On Tue, May 03, 2016 at 12:03:52PM +0200, Yegor Yefremov wrote:
> On Thu, Apr 28, 2016 at 4:37 PM, Bin Liu <b-liu@ti.com> wrote:
> > Hi,
> >
> > On Thu, Apr 28, 2016 at 09:51:37AM +0300, Maxim Uvarov wrote:
> >
> > [snip]
> >
> >> Hello Bin,
> >>
> >> yes, it also works with that reset and go to finish:
> >>
> >> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> >> index c3d5fc9..8cd98e7 100644
> >> --- a/drivers/usb/musb/musb_host.c
> >> +++ b/drivers/usb/musb/musb_host.c
> >> @@ -1599,6 +1599,10 @@ void musb_host_rx(struct musb *musb, u8 epnum)
> >> status = -EPROTO;
> >> musb_writeb(epio, MUSB_RXINTERVAL, 0);
> >>
> >> + rx_csr &= ~MUSB_RXCSR_H_ERROR;
> >> + musb_writew(epio, MUSB_RXCSR, rx_csr);
> >> +
> >> + goto finish;
> >> } else if (rx_csr & MUSB_RXCSR_DATAERROR) {
> >>
> >> if (USB_ENDPOINT_XFER_ISOC != qh->type) {
> >>
> >
> > Thanks for testing it.
>
> Have tested your patch and now both FT4232 and Huawei don't freeze on removal.
>
> Bin, Max thanks for fixing this issue.
>
> Tested-by: Yegor Yefremov <yegorslists@googlemail.com>

Thanks for testing.

Can you please test the patch [1] instead? I'd like to use it as the
fix.

Regards,
-Bin.

[1] http://marc.info/?l=linux-usb&m=146222355213935&w=2

\
 
 \ /
  Last update: 2016-05-03 16:01    [W:0.119 / U:32.792 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site