Messages in this thread | | | Subject | Re: [PATCH 5/7] iio: adc: ad7887: use iio helper function to guarantee direct mode | From | Jonathan Cameron <> | Date | Sun, 29 May 2016 19:35:55 +0100 |
| |
On 25/05/16 11:38, Daniel Baluta wrote: > On Tue, May 24, 2016 at 10:18 PM, Alison Schofield <amsfield22@gmail.com> wrote: >> Replace the code that guarantees the device stays in direct mode >> with iio_device_claim_direct_mode() which does same. >> >> Signed-off-by: Alison Schofield <amsfield22@gmail.com> >> Cc: Daniel Baluta <daniel.baluta@gmail.com> > > Acked-by: Daniel Baluta <daniel.baluta@gmail.com> Applied - thanks.
Jonathan > >> --- >> drivers/iio/adc/ad7887.c | 11 +++++------ >> 1 file changed, 5 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/iio/adc/ad7887.c b/drivers/iio/adc/ad7887.c >> index 2d3c397..ee2ccc1 100644 >> --- a/drivers/iio/adc/ad7887.c >> +++ b/drivers/iio/adc/ad7887.c >> @@ -156,12 +156,11 @@ static int ad7887_read_raw(struct iio_dev *indio_dev, >> >> switch (m) { >> case IIO_CHAN_INFO_RAW: >> - mutex_lock(&indio_dev->mlock); >> - if (iio_buffer_enabled(indio_dev)) >> - ret = -EBUSY; >> - else >> - ret = ad7887_scan_direct(st, chan->address); >> - mutex_unlock(&indio_dev->mlock); >> + ret = iio_device_claim_direct_mode(indio_dev); >> + if (ret) >> + return ret; >> + ret = ad7887_scan_direct(st, chan->address); >> + iio_device_release_direct_mode(indio_dev); >> >> if (ret < 0) >> return ret; >> -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |