lkml.org 
[lkml]   [2016]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mfd: max77620: Fix FPS switch statements
From
Date
On 5/12/2016 1:52 PM, Laxman Dewangan wrote:
>
> On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote:
>> When configuring FPS during probe, assuming a DT node is present for
>> FPS, the code can run into a problem with the switch statements in
>> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
>> in the case of chip->chip_id == MAX77620, it will set
>> fps_[mix|max]_period but then fall through to the default switch case
>> and return -EINVAL. Returning this from max77620_config_fps() will
>> cause probe to fail.
>>
>
> Thanks for fixes.
> Missed when converting if-else to switch.
>
> Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
>

Lee, I noticed this hasn't been merged yet, but without it platforms
using the max77620 can easily (if it has FPS nodes) fail to probe. Is
there anything blocking it?

-rhyland

--
nvpublic

\
 
 \ /
  Last update: 2016-05-27 23:01    [W:0.197 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site