lkml.org 
[lkml]   [2016]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] arm: tegra124: remove commas from unit addresses
From
Date
On 05/27/2016 10:27 AM, Marcel Ziswiler wrote:
> Remove commas from unit addresses as suggested by Rob Herring upon me
> posting initial Apalis TK1 support:
>
> http://article.gmane.org/gmane.linux.ports.tegra/26608

> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts

> - gpu@0,57000000 {
> + gpu@57000000 {
> /*
> * Node left disabled on purpose - the bootloader will enable
> * it after having set the VPR up

The last time a similar patch was proposed[1], I pointed out that U-Boot
uses the node name to enable the node, so this change will break GPU
functionality on this board. U-Boot has since been updated to find the
node to enable using compatible value rather than hard-coding the node
name, but this doesn't help people with existing bootloader binaries;
kernel changes shouldn't force them to upgrade the bootloader. I think
the DT node names are part of the ABI and shouldn't be changed. We can
fix this for completely new SoCs, but not existing SoCs.

[1] http://www.spinics.net/lists/devicetree/msg122164.html "[PATCH] ARM:
tegra: Remove 0, prefix from unit-addresses".

\
 
 \ /
  Last update: 2016-05-27 20:41    [W:0.053 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site