Messages in this thread | | | Subject | Re: [PATCH 3/3] ibmvscsis: clean up functions | From | Joe Perches <> | Date | Wed, 25 May 2016 07:44:39 -0700 |
| |
On Wed, 2016-05-25 at 09:17 -0500, Bryant G. Ly wrote: > From: bryantly <bryantly@linux.vnet.ibm.com>
Please use your whole name here and for your sign-off like:
From: Bryant G. Ly <bryantly@linux.vnet.ibm.com> Signed-off-by: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
> This patch removes forward declarations and re-organizes the > functions within the driver. This patch also fixes MAINTAINERS > for ibmvscsis.
trivial note:
> diff --git a/drivers/scsi/ibmvscsi/ibmvscsis.c b/drivers/scsi/ibmvscsi/ibmvscsis.c [] > static inline long h_copy_rdma(s64 length, u64 sliobn, u64 slioba, > u64 dliobn, u64 dlioba) > { >
Functions like this would be less indented and less line wrapped for 80 columns if they were written:
if (!se_cmd->residual_count) return;
[unindented one level...]
etc...
| |