Messages in this thread | | | Subject | Re: [PATCH] soc: qcom: provide mechanism for drivers to access L2 registers | From | Neil Leeder <> | Date | Mon, 23 May 2016 11:43:15 -0400 |
| |
On 5/20/2016 05:19 PM, Stephen Boyd wrote: > On 05/20/2016 12:13 PM, Neil Leeder wrote: >> diff --git a/drivers/soc/qcom/l2-accessors.c b/drivers/soc/qcom/l2-accessors.c >> new file mode 100644 >> index 0000000..fbb69bd >> --- /dev/null >> +++ b/drivers/soc/qcom/l2-accessors.c >> @@ -0,0 +1,66 @@ >> +/* >> + * Copyright (c) 2014-2016 The Linux Foundation. All rights reserved. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 and >> + * only version 2 as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> + >> +#include <linux/spinlock.h> >> +#include <linux/module.h> > > export.h instead?
OK, will address in v2
> >> +#include <linux/soc/qcom/l2-accessors.h> >> +#include <asm/cputype.h> >> +#include <asm/sysreg.h> > > Is there a patch to add sysreg.h to arch/arm? It would be nice to use > one l2 accessor API on arm64 and arm. >
Sounds like a good thing for the next person who submits a krait L2 patch to consider.
-- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
| |