Messages in this thread | | | Date | Sat, 21 May 2016 00:09:30 -0400 | From | Waiman Long <> | Subject | Re: [PATCH] locking/mutex: Set and clear owner using WRITE_ONCE() |
| |
On 05/20/2016 09:00 PM, Davidlohr Bueso wrote: > On Fri, 20 May 2016, Waiman Long wrote: > >> I think mutex-debug.h also needs similar changes for completeness. > > Maybe, but given that with debug the wait_lock is unavoidable, doesn't > this send the wrong message? > > Thanks, > Davidlohr
You are right. Optimistic spinning is disabled when DEBUG_MUTEXES is true. So WRITE_ONCE() is not really needed. However, I think we should have at least a comment in mutex-debug.h as to why the owner field is handled differently from mutex.h.
Cheers, Longman
| |