lkml.org 
[lkml]   [2016]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] locking/mutex: Set and clear owner using WRITE_ONCE()
On 05/20/2016 09:00 PM, Davidlohr Bueso wrote:
> On Fri, 20 May 2016, Waiman Long wrote:
>
>> I think mutex-debug.h also needs similar changes for completeness.
>
> Maybe, but given that with debug the wait_lock is unavoidable, doesn't
> this send the wrong message?
>
> Thanks,
> Davidlohr

You are right. Optimistic spinning is disabled when DEBUG_MUTEXES is
true. So WRITE_ONCE() is not really needed. However, I think we should
have at least a comment in mutex-debug.h as to why the owner field is
handled differently from mutex.h.

Cheers,
Longman

\
 
 \ /
  Last update: 2016-05-21 06:41    [W:0.078 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site