Messages in this thread | | | Subject | Re: [PATCH 03/20] staging: comedi: drivers: rename PLX PCI 9080 register offsets | From | Ian Abbott <> | Date | Fri, 20 May 2016 17:30:42 +0100 |
| |
On 20/05/16 17:21, Hartley Sweeten wrote: > On Friday, May 20, 2016 6:49 AM, Ian Abbott wrote: >> Rename the macros in "plx9080.h" that define the offsets of registers, >> following the pattern `PLX_REG_<NAME>`, where `<NAME>` is the register >> name from the PLX PCI 9080 Data Book. >> >> Add defines for the "Mailbox" registers, and add parameterized macros >> for the mailbox registers and the DMA control registers. Make use of >> the parameterized versions of the macros where it seems appropriate. >> >> The registers for supporting the I2O (Intelligent Input/Output) feature >> are largely left undefined, just defining enough to allow the I2O >> feature to be disabled. >> >> Signed-off-by: Ian Abbott <abbotti@mev.co.uk> > > Ian, > > Just an comment on your renaming. > > You also renamed the registers in the daqbook2000 driver in the > <driver>_REG_<name> format. Personally I prefer the format to be > <driver>_<name>_REG. That way a grep for <driver>_<name> will > return both the register and bit uses. > > Currently the <driver>_REG_<name> form is not as common in comedi. > Looks like it's only used in amcc_35933.h and will be in daqboard2000.c. > > The <driver>_<name>_REG form is used a lot. > > Not a big deal, just a comment.
It makes it easier to distinguish the register offsets from the register values, imho.
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=- -=( Web: http://www.mev.co.uk/ )=-
| |