Messages in this thread | | | From | Hartley Sweeten <> | Subject | RE: [PATCH v2 06/14] staging: comedi: daqboard2000: rename register offset macros | Date | Wed, 18 May 2016 22:45:17 +0000 |
| |
On Wednesday, May 18, 2016 5:37 AM, Ian Abbott wrote: > Rename the macros defining register offsets to avoid CamelCase, and to > use namespace associated with the driver. > > Signed-off-by: Ian Abbott <abbotti@mev.co.uk> > Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com> > --- > Other CamelCase issues in this patch will be dealt with by later > patches in the series. > > v2: Shortened prefix from `DAQBOARD2000_` to `DB2K_`. > --- > drivers/staging/comedi/drivers/daqboard2000.c | 112 ++++++++++++++------------ > 1 file changed, 61 insertions(+), 51 deletions(-)
[snip]
+#define DB2K_REG_DIO_P2_EXP_IO_16_BIT(x) (0xc0 + (x) * 2) /* s16 */
You slipped an extra space in here: WARNING: please, no space before tabs #184: FILE: drivers/staging/comedi/drivers/daqboard2000.c:184: +#define DB2K_REG_DIO_P2_EXP_IO_16_BIT(x) ^I(0xc0 + (x) * 2) /* s16 */$
Regards, Hartley
| |