lkml.org 
[lkml]   [2016]   [May]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-4.6/drivers/crypto/ux500/hash/hash_core.c: 2 * possible bad size ?
On Mon, May 16, 2016 at 07:13:12PM +0100, David Binderman wrote:
> Hello there,
>
> 1.
>
> linux-4.6/drivers/crypto/ux500/hash/hash_core.c:784]: (warning) Division by
> result of sizeof(). memmove() expects a size in bytes, did you intend to
> multiply instead?
>
> Source code is
>
> memmove(req_ctx->state.buffer,
> device_data->state.buffer,
> HASH_BLOCK_SIZE / sizeof(u32));
>
> Maybe better code
>
> memmove(req_ctx->state.buffer,
> device_data->state.buffer,
> HASH_BLOCK_SIZE);
>
> 2.
>
> linux-4.6/drivers/crypto/ux500/hash/hash_core.c:835]: (warning) Division by
> result of sizeof(). memmove() expects a size in bytes, did you intend to
> multiply instead?
>
> Duplicate.

Thanks for noticing these bugs. This driver hasn't been maintained
since 2012, so unless someone steps up I'm going to just delete it.

Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

\
 
 \ /
  Last update: 2016-05-18 10:21    [W:0.228 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site