Messages in this thread | | | Subject | Re: [RFC][PATCH 0/7] locking/rwsem: Convert rwsem count to atomic_long_t | From | Jason Low <> | Date | Tue, 17 May 2016 10:06:44 -0700 |
| |
On Tue, 2016-05-17 at 13:09 +0200, Peter Zijlstra wrote: > On Mon, May 16, 2016 at 06:12:25PM -0700, Linus Torvalds wrote: > > On Mon, May 16, 2016 at 5:37 PM, Jason Low <jason.low2@hpe.com> wrote: > > > > > > This rest of the series converts the rwsem count variable to an atomic_long_t > > > since it is used it as an atomic variable. This allows us to also remove > > > the rwsem_atomic_{add,update} abstraction and reduce 100+ lines of code. > > > > I would suggest you merge all the "remove rwsem_atomic_{add,update}" > > patches into a single patch. > > > > I don't see the advantage to splitting those up by architecture, and > > it does add noise to the series. > > > > Other than that it all looks fine to me. > > OK, done.
Right, they all fit under the same category of "Removing rwsem_atomic_{add,update}", so it makes sense to fold them into one patch.
Thanks, Jason
| |