lkml.org 
[lkml]   [2016]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.5 071/101] qla1280: Dont allocate 512kb of host tags
    Date
    4.5-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johannes Thumshirn <jthumshirn@suse.de>

    commit 2bcbc81421c511ef117cadcf0bee9c4340e68db0 upstream.

    The qla1280 driver sets the scsi_host_template's can_queue field to 0xfffff
    which results in an allocation failure when allocating the block layer tags
    for the driver's queues. This was introduced with the change for host wide
    tags in commit 64d513ac31b - "scsi: use host wide tags by default".

    Reduce can_queue to MAX_OUTSTANDING_COMMANDS (512) to solve the allocation
    error.

    Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
    Fixes: 64d513ac31b - "scsi: use host wide tags by default"
    Cc: Laura Abbott <labbott@redhat.com>
    Cc: Michael Reed <mdr@sgi.com>
    Reviewed-by: Laurence Oberman <loberman@redhat.com>
    Reviewed-by: Lee Duncan <lduncan@suse.com>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: James Bottomley <jejb@linux.vnet.ibm.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/qla1280.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/qla1280.c
    +++ b/drivers/scsi/qla1280.c
    @@ -4214,7 +4214,7 @@ static struct scsi_host_template qla1280
    .eh_bus_reset_handler = qla1280_eh_bus_reset,
    .eh_host_reset_handler = qla1280_eh_adapter_reset,
    .bios_param = qla1280_biosparam,
    - .can_queue = 0xfffff,
    + .can_queue = MAX_OUTSTANDING_COMMANDS,
    .this_id = -1,
    .sg_tablesize = SG_ALL,
    .use_clustering = ENABLE_CLUSTERING,

    \
     
     \ /
      Last update: 2016-05-17 04:01    [W:4.086 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site