lkml.org 
[lkml]   [2016]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next] bpf: arm64: remove callee-save registers use for tmp registers
From
Hi Yang,

On Mon, May 16, 2016 at 4:09 PM, Yang Shi <yang.shi@linaro.org> wrote:
> In the current implementation of ARM64 eBPF JIT, R23 and R24 are used for
> tmp registers, which are callee-saved registers. This leads to variable size
> of JIT prologue and epilogue. The latest blinding constant change prefers to
> constant size of prologue and epilogue. AAPCS reserves R9 ~ R15 for temp
> registers which not need to be saved/restored during function call. So, replace
> R23 and R24 to R10 and R11, and remove tmp_used flag.
>
> CC: Zi Shen Lim <zlim.lnx@gmail.com>
> CC: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: Yang Shi <yang.shi@linaro.org>
> ---

Couple suggestions, but otherwise:
Acked-by: Zi Shen Lim <zlim.lnx@gmail.com>

1. Update the diagram. I think it should now be:

- * BPF fp register => -80:+-----+ <= (BPF_FP)
+ * BPF fp register => -64:+-----+ <= (BPF_FP)

2. Add a comment in commit log along the lines of: this is an
optimization saving 2 instructions per jited BPF program.

Thanks :)

z

> Apply on top of Daniel's blinding constant patchset.
>
> arch/arm64/net/bpf_jit_comp.c | 32 ++++----------------------------
> 1 file changed, 4 insertions(+), 28 deletions(-)
>

\
 
 \ /
  Last update: 2016-05-17 02:01    [W:0.252 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site