lkml.org 
[lkml]   [2016]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dell_rbu: Don't fallback to userhelper when loading firmware
From
Date
On 05/16/2016 08:41 AM, Mario Limonciello wrote:
> dell_rbu previously would allow a userspace application to craft the
> payload after dell_rbu was loaded and abuse the udev userspace API.
>
> Instead require the payload to be crafted and placed in
> /lib/firmware/dell_rbu ahead of time.
>
> This adjusts dell_rbu to immediately load the firmware from
> /lib/firmware/dell_rbu when "init" is passed into image_type using the
> kernel helper.

Looks like you missed the Signed-off-by line.

Can you also drop the Kconfig dependency on CONFIG_FW_LOADER_USER_HELPER?

Thanks,
Laura

> ---
> drivers/firmware/dell_rbu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c
> index d5f5b98..5ecf043 100644
> --- a/drivers/firmware/dell_rbu.c
> +++ b/drivers/firmware/dell_rbu.c
> @@ -677,7 +677,7 @@ static ssize_t write_rbu_image_type(struct file *filp, struct kobject *kobj,
> if (!rbu_data.entry_created) {
> spin_unlock(&rbu_data.lock);
> req_firm_rc = request_firmware_nowait(THIS_MODULE,
> - FW_ACTION_NOHOTPLUG,
> + FW_ACTION_HOTPLUG,
> "dell_rbu",
> &rbu_device->dev,
> GFP_KERNEL,
>

\
 
 \ /
  Last update: 2016-05-16 19:41    [W:1.132 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site