Messages in this thread | | | Date | Fri, 13 May 2016 15:04:53 -0700 | Subject | Re: [PATCH v2 2/4] phy: rockchip-emmc: configure frequency range and drive impedance | From | Doug Anderson <> |
| |
Hi,
On Fri, May 13, 2016 at 2:09 PM, Brian Norris <briannorris@chromium.org> wrote: > From: Shawn Lin <shawn.lin@rock-chips.com> > > Signal integrity analysis has suggested we set these values. Do this in > power_on(), so that they get reconfigured after suspend/resume. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > v2: > * Sent only patch 2/4 with version 2, to avoid spamming; will move on to v3 > for all patches if I need to send another > * Drop 170 MHz comment; this was only applicable to a subtly different Arasan > PHY > > drivers/phy/phy-rockchip-emmc.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+)
As per my comments on v1, this is a sane starting point and seems like a good idea to land. Hopefully someone at Rockchip can pick things up and continue making this more configurable.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |