lkml.org 
[lkml]   [2016]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/2] ARM64: dts: rockchip: add sdhci/emmc for rk3399
    On Fri, May 13, 2016 at 02:42:06PM -0700, Doug Anderson wrote:
    > On Thu, May 12, 2016 at 3:35 PM, Brian Norris <briannorris@chromium.org> wrote:
    > > + emmc_phy: phy@f780 {
    > > + compatible = "rockchip,rk3399-emmc-phy";
    > > + reg = <0xf780 0x20>;
    >
    > This is slightly wrong. It should be:
    >
    > reg = <0xf780 0x24>;
    >
    > The status register is at an offset of 0x20 and is 4 bytes big, so we
    > need room for it.

    Fixed.

    > After that is fixed, feel free to add my Reviewed-by tag.

    Done.

    Thanks for the review.

    Brian

    \
     
     \ /
      Last update: 2016-05-14 00:01    [W:4.794 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site