Messages in this thread | | | Subject | Re: [PATCH] staging/rdma/hfi1: use RCU_INIT_POINTER() when NULLing. | From | Doug Ledford <> | Date | Fri, 13 May 2016 15:38:34 -0400 |
| |
On 05/01/2016 08:35 AM, Muhammad Falak R Wani wrote: > It is safe to use RCU_INIT_POINTER() to NULL a pointer, instead of > rcu_assign_pointer(). > This results in slightly smaller/faster code. > > Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com> > --- > drivers/staging/rdma/hfi1/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rdma/hfi1/init.c b/drivers/staging/rdma/hfi1/init.c > index cfcdc16..34e0f90 100644 > --- a/drivers/staging/rdma/hfi1/init.c > +++ b/drivers/staging/rdma/hfi1/init.c > @@ -1303,7 +1303,7 @@ static void cleanup_device_data(struct hfi1_devdata *dd) > > spin_lock(&ppd->cc_state_lock); > cc_state = get_cc_state(ppd); > - rcu_assign_pointer(ppd->cc_state, NULL); > + RCU_INIT_POINTER(ppd->cc_state, NULL); > spin_unlock(&ppd->cc_state_lock); > > if (cc_state) >
Thanks, applied.
-- Doug Ledford <dledford@redhat.com> GPG KeyID: 0E572FDD
[unhandled content-type:application/pgp-signature] | |