lkml.org 
[lkml]   [2016]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] perf diff: Fix indentation of stalled backend cycle
Hi Arnaldo,

On Fri, May 13, 2016 at 08:48:48AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, May 13, 2016 at 03:01:01PM +0900, Namhyung Kim escreveu:
> > The commit 140aeadc1fb5 ("perf stat: Abstract stat metrics printing")
> > changed way to print shadow metrics, but it missed to update the width
> > of stalled backend cycles event to 7.2% like others. This resulted in
> > misaligned output like below:
>
> Thanks for pointing out the cset that introduced the problem, helps in
> reviewing! Next time please consider adding it right before your
> Signed-off-by line as:
>
> Fixes: 140aeadc1fb5 ("perf stat: Abstract stat metrics printing")
>
> Thanks!

Ok, will do it later. Btw I found the subject line should start with
'perf stat' instead of 'perf diff'..

Thanks,
Namhyung


>
> > Performance counter stats for 'pwd':
> >
> > 0.638313 task-clock (msec) # 0.567 CPUs utilized
> > 0 context-switches # 0.000 K/sec
> > 0 cpu-migrations # 0.000 K/sec
> > 54 page-faults # 0.085 M/sec
> > 885,600 cycles # 1.387 GHz
> > 558,438 stalled-cycles-frontend # 63.06% frontend cycles idle
> > 431,355 stalled-cycles-backend # 48.71% backend cycles idle
> > 674,956 instructions # 0.76 insn per cycle
> > # 0.83 stalled cycles per insn
> > 130,380 branches # 204.257 M/sec
> > <not counted> branch-misses
> >
> > 0.001125426 seconds time elapsed
> >
> > Cc: Andi Kleen <andi@firstfloor.org>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
> > tools/perf/util/stat-shadow.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> > index fdb71961143e..61200fcac5ef 100644
> > --- a/tools/perf/util/stat-shadow.c
> > +++ b/tools/perf/util/stat-shadow.c
> > @@ -188,7 +188,7 @@ static void print_stalled_cycles_backend(int cpu,
> >
> > color = get_ratio_color(GRC_STALLED_CYCLES_BE, ratio);
> >
> > - out->print_metric(out->ctx, color, "%6.2f%%", "backend cycles idle", ratio);
> > + out->print_metric(out->ctx, color, "%7.2f%%", "backend cycles idle", ratio);
> > }
> >
> > static void print_branch_misses(int cpu,
> > --
> > 2.8.2

\
 
 \ /
  Last update: 2016-05-13 16:01    [W:1.024 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site