Messages in this thread | | | Date | Thu, 12 May 2016 10:46:52 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH perf/core v7 01/21] tools/perf: Fix lsdir to set errno correctly |
| |
Hi Arnaldo,
On Wed, 11 May 2016 10:59:39 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> Em Wed, May 11, 2016 at 10:51:27PM +0900, Masami Hiramatsu escreveu: > > Fix lsdir() to set correct positive error number (ENOMEM). > > Since "errno" must have a positive error number instead of > > negative number, fix lsdir to set it correctly. > > Masami, please try to: > > 1) Follow existing convention when writing the patch Subject line, when > in doubt: git log tools/perf/util/util.c and check, in this case I > changed it to "perf tools: Fix lsdir to set errno correctly"
OK, I see.
> 2) Add a Fixed line, for this case I used 'git blame' and added: > > Fixes: e1ce726e1db2 ("perf tools: Add lsdir() helper to read a directory") > > This helps reviewing (now and down the line), because one can go more > quickly check what was the intention in the original patch, to see if it > is really a fix.
Oops! I just missed that. Of course I will do.
> > In some cases this looks trivial, like in this patch, sometimes its > not...
I see.
Thank you,
> > Thanks, > > - Arnaldo > > > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org> > > --- > > tools/perf/util/util.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/util.c b/tools/perf/util/util.c > > index 01c9433..eab077a 100644 > > --- a/tools/perf/util/util.c > > +++ b/tools/perf/util/util.c > > @@ -139,7 +139,7 @@ struct strlist *lsdir(const char *name, > > > > list = strlist__new(NULL, NULL); > > if (!list) { > > - errno = -ENOMEM; > > + errno = ENOMEM; > > goto out; > > } > >
-- Masami Hiramatsu <mhiramat@kernel.org>
| |