Messages in this thread | | | From | Heiko Stuebner <> | Subject | Re: [PATCH 2/2] ARM64: dts: rockchip: enable eMMC for rk3399 EVB | Date | Thu, 12 May 2016 00:36:20 +0200 |
| |
Am Mittwoch, 11. Mai 2016, 15:32:33 schrieb Brian Norris: > On Wed, May 11, 2016 at 04:51:58PM +0200, Heiko Stuebner wrote: > > Hi Brian, > > > > Am Dienstag, 10. Mai 2016, 17:02:55 schrieb Brian Norris: > > > The 'mmc-hs400-enhanced-strobe' property has been acked by Rob > > > Herring, > > > though it's still not merged. > > > > The commit message should describe the actual change not the volatile > > environment surrounding it :-) . > > > > When I apply this patch the property-binding will have made it into a > > maintainer-tree so is not valid anymore then. That is more material for > > the "comment-section" below the "---" > > Of course. I think I just felt guilty without a commit message :)
I really prefer a (even simple) message being there - although I'm not as strict as Greg and Felipe ;-) , and in cases like this I think something like "enable the newly added emmc node on the rk3399 evaluation board" should be sufficient.
Heiko
| |