lkml.org 
[lkml]   [2016]   [May]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/10] perf, tools, stat: Avoid fractional digits for integer scales
Em Wed, May 11, 2016 at 03:00:31PM +0200, Jiri Olsa escreveu:
> On Sat, May 07, 2016 at 12:24:25PM -0700, Andi Kleen wrote:
> > > > if (csv_output) {
> > > > - fmt = sc != 1.0 ? "%.2f%s" : "%.0f%s";
> > > > + fmt = floor(sc) != sc ? "%.2f%s" : "%.0f%s";
> > > > } else {
> > > > if (big_num)
> > > > - fmt = sc != 1.0 ? "%'18.2f%s" : "%'18.0f%s";
> > > > + fmt = floor(sc) != sc ? "%'18.2f%s" : "%'18.0f%s";
> > > > else
> > > > - fmt = sc != 1.0 ? "%18.2f%s" : "%18.0f%s";
> > > > + fmt = floor(sc) != sc ? "%18.2f%s" : "%18.0f%s";
> > >
> > > how about the rest of the code? we display % also in print_running
> > > and print_noise_pct functions and maybe some place else
> >
> > For those it doesn't matter. In fact it's probably better there
> > to always show the fractions.
> >
> > It is just confusing for metrics.
>
> ok, let's try and see, we can always follow up
> with the rest if there's a need
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Missed this one, applied.

- Arnaldo

\
 
 \ /
  Last update: 2016-05-11 19:01    [W:1.779 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site