Messages in this thread | | | Subject | Re: [PATCH v6 07/13] x86/xsaves: Fix PTRACE frames for XSAVES | From | Dave Hansen <> | Date | Wed, 11 May 2016 07:50:56 -0700 |
| |
On 05/10/2016 04:29 PM, Yu-cheng Yu wrote: > XSAVES uses compacted format and is a kernel instruction. The kernel > should use standard-format, non-supervisor state data for PTRACE. > > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@intel.com>
This looks fine. There are a few comments that could use some sprucing up, like:
+ /* + * Reject if the user sets any forbidden features. + */
But it's minor stuff.
Reviewed-by: Dave Hansen <dave.hansen@intel.com>
| |