lkml.org 
[lkml]   [2016]   [May]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/3] Input - soc_button_array: use gpio_is_valid()
From
On Tue, May 10, 2016 at 12:37 PM, Benjamin Tissoires
<benjamin.tissoires@redhat.com> wrote:

> @@ -92,7 +93,7 @@ soc_button_device_create(struct platform_device *pdev,
> continue;
>
> gpio = soc_button_lookup_gpio(&pdev->dev, info->acpi_index);
> - if (gpio < 0)
> + if (gpio_is_valid(gpio))

Shouldn't it be "if (!gpio_is_valid(gpio))" ?

\
 
 \ /
  Last update: 2016-05-10 18:21    [W:1.483 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site