Messages in this thread | | | Date | Tue, 10 May 2016 12:56:18 -0300 | Subject | Re: [PATCH 1/3] Input - soc_button_array: use gpio_is_valid() | From | Fabio Estevam <> |
| |
On Tue, May 10, 2016 at 12:37 PM, Benjamin Tissoires <benjamin.tissoires@redhat.com> wrote:
> @@ -92,7 +93,7 @@ soc_button_device_create(struct platform_device *pdev, > continue; > > gpio = soc_button_lookup_gpio(&pdev->dev, info->acpi_index); > - if (gpio < 0) > + if (gpio_is_valid(gpio))
Shouldn't it be "if (!gpio_is_valid(gpio))" ?
| |