Messages in this thread | | | Date | Tue, 10 May 2016 14:08:45 +0200 | Subject | Re: [PATCH v8 2/3] gpio: mmio: add DT support for memory-mapped GPIOs | From | Linus Walleij <> |
| |
On Sun, May 8, 2016 at 3:08 PM, Christian Lamparter <chunkeey@googlemail.com> wrote:
> From: Álvaro Fernández Rojas <noltari@gmail.com> > > This patch adds support for defining memory-mapped GPIOs which > are compatible with the existing gpio-mmio interface.
Overall very nice, just waiting for the next version.
> The first user for this binding is "wd,mbl-gpio".
And that binding defines that we have a register named "dat".
> + if (of_property_read_bool(dev->of_node, "no-output"))
And then this too.
Do we want these generic MMIO bindings (dat, no-output) in a special document like Documentation/devicetree/bindings/gpio/gpio-mmio.txt?
Going forward?
This patch set mainly deals with refactorings, but in the long run we want to slim things down a bit and use standard bindings I think.
Yours, Linus Walleij
| |