Messages in this thread | | | Subject | Re: [PATCH v2 13/22] ARM: dts: exynos: Move common nodes to exynos5.dtsi | From | Krzysztof Kozlowski <> | Date | Tue, 10 May 2016 07:30:38 +0200 |
| |
On 05/09/2016 11:25 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/08/2016 03:05 PM, Krzysztof Kozlowski wrote: >> Exynos5420 and Exynos5250 share some nodes: the PWM and syscon >> (sysreg_system_controller). Move them to parent DTSI to avoid >> duplication. >> >> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >> --- > > I see that the i2c_[0-3] nodes are also the same in both DTSI. Do you > think that makes sense to also move those to exynos5.dtsi as well?
Thanks, that is a good suggestion. I didn't add the I2C and its children to Odroid XU yet but probably having the nodes defined won't hurt. Especially that they are disabled by default.
Best regards, Krzysztof
> In any case that can be made as a follow-up, so: > > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com> > > Best regards, >
| |