Messages in this thread | | | From | Felipe Balbi <> | Subject | RE: [PATCH v2 0/3] Improvement, fix and new entry for dwc3 debugfs | Date | Thu, 07 Apr 2016 08:22:27 +0300 |
| |
HI
"Du, Changbin" <changbin.du@intel.com> writes: >> before I review your patches, one comment >> >> changbin.du@intel.com writes: >> > From: "Du, Changbin" <changbin.du@intel.com> >> > >> > The first patch removed unnecessary checking for debugfs api call; >> > The second patch fix a memory leak issue; >> > The third patch add one new entry to debufs. >> > >> > Du, Changbin (3): >> > usb: dwc3: make dwc3_debugfs_init return value be void >> >> this is _not_ a fix >> >> > usb: dwc3: free dwc->regset on dwc3_debugfs_exit >> >> but this is. Why isn't this, at least, the first patch in the list ? In >> fact, it would be preferred that this patch be sent by itself and the >> following two patches should be on another branch completely without any >> dependencies to the memory leak fix. >> >> -- >> Balbi > > Sure, Balbi. This will be better. I will send out patch v3 and another independent > patch. Also include changelog as Greg required. Thanks for checking.
thanks, that way we can get the fix during the -rc cycle and the other two patches on next merge window ;-)
-- balbi [unhandled content-type:application/pgp-signature]
| |