lkml.org 
[lkml]   [2016]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 09/30] Add tile-specific parity functions
From
Date
在 2016年04月06日 21:27, Chris Metcalf 写道:
> On 4/6/2016 5:08 AM, zengzhaoxiu@163.com wrote:
>> From: Zhaoxiu Zeng<zhaoxiu.zeng@gmail.com>
>>
>> Signed-off-by: Zhaoxiu Zeng<zhaoxiu.zeng@gmail.com>
>> ---
>> arch/tile/include/asm/bitops.h | 26 ++++++++++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>
> Since all the code you are adding here is architecture-independent,
> I think it would make more sense to have it be in a file like
> include/asm-generic/bitops/parity-popcount.h, which can then
> be included from arch/tile/include/asm/bitops.h.
>

Agreed, thanks!

\
 
 \ /
  Last update: 2016-04-07 06:01    [W:0.134 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site