Messages in this thread | | | Subject | Re: [PATCH v2 09/30] Add tile-specific parity functions | From | Zeng Zhaoxiu <> | Date | Thu, 7 Apr 2016 11:55:55 +0800 |
| |
在 2016年04月06日 21:27, Chris Metcalf 写道: > On 4/6/2016 5:08 AM, zengzhaoxiu@163.com wrote: >> From: Zhaoxiu Zeng<zhaoxiu.zeng@gmail.com> >> >> Signed-off-by: Zhaoxiu Zeng<zhaoxiu.zeng@gmail.com> >> --- >> arch/tile/include/asm/bitops.h | 26 ++++++++++++++++++++++++++ >> 1 file changed, 26 insertions(+) > > Since all the code you are adding here is architecture-independent, > I think it would make more sense to have it be in a file like > include/asm-generic/bitops/parity-popcount.h, which can then > be included from arch/tile/include/asm/bitops.h. >
Agreed, thanks!
| |