Messages in this thread | | | Date | Wed, 6 Apr 2016 14:31:18 -0700 | Subject | Re: [PATCH] HID: simplify implement() a bit | From | Doug Anderson <> |
| |
Dmitry,
On Wed, Apr 6, 2016 at 10:19 AM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > The 'size' variable is not really needed, and we can also shift constant > in the loop body when masking off existing bits. > > Also we do not have to us 64 bit calculations if we take an extra > branch. > > Suggested-by: Doug Anderson <dianders@chromium.org> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > drivers/hid/hid-core.c | 33 +++++++++++++++------------------ > 1 file changed, 15 insertions(+), 18 deletions(-)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |