Messages in this thread | | | From | Hartley Sweeten <> | Subject | RE: [PATCH] staging: comedi: das1800: remove unused variable | Date | Wed, 6 Apr 2016 16:19:20 +0000 |
| |
On Wednesday, April 06, 2016 2:41 AM, Ian Abbott wrote: > On 06/04/16 02:21, Hartley Sweeten wrote: >> On Tuesday, April 05, 2016 7:23 AM, Sudip Mukherjee wrote: >>> The variable unipolar was never used. >>> >>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> >>> --- >>> >>> There may be a chance that reading from DAS1800_CONTROL_C is necessary >>> before reading from DAS1800_STATUS. If that is true then please discard >>> this patch. >> >> Actually the driver has a bug here. >> >> The analog input samples should be munged if the inputs are configured for >> bipolar mode. >> >> I have a series almost ready that cleans up this driver and fixes the bug. > > Hi Hartley, can the bug fix be placed at the top of your patch series?
I'll split it out as a separate patch and post it shortly.
Thanks, Hartley
| |