lkml.org 
[lkml]   [2016]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRE: [PATCH] usb: dwc3: add debugfs node to dump FIFO/Queue available space
Date

Hi,

(please make sure to break your lines at
80-characters. Documentation/email-clients.txt has several tips for
different email clients ;-))

"Du, Changbin" <changbin.du@intel.com> writes:
>> > @@ -648,6 +687,12 @@ int dwc3_debugfs_init(struct dwc3 *dwc)
>> > goto err1;
>> > }
>> >
>> > + file = debugfs_create_file("fifo", S_IRUGO, root, dwc,
>> &dwc3_fifo_fops);
>> > + if (!file) {
>> > + ret = -ENOMEM;
>>
>> Um, no, that's not the error here. You shouldn't care at all about
>> debugfs api call results. Just keep moving on here please.
>>
>> thanks,
>>
>> greg k-h
>
> Agree with you. I will create another patch to cleanup this piece of
> code.

cool, thanks

> And I found a memory leak issue there, dwc->regset never
> released. Will also fix it.

good catch, thanks for fixing it.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2016-04-06 14:41    [W:1.323 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site