lkml.org 
[lkml]   [2016]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency model
On Wed, Apr 06, 2016 at 01:32:48AM +0800, Minfei Huang wrote:
> On 03/25/16 at 02:34P, Josh Poimboeuf wrote:
> > +static int klp_check_stack(struct task_struct *task)
> > +{
> > + static unsigned long entries[MAX_STACK_ENTRIES];
> > + struct stack_trace trace;
> > + struct klp_object *obj;
> > + struct klp_func *func;
> > + int ret;
> > +
> > + trace.skip = 0;
> > + trace.nr_entries = 0;
> > + trace.max_entries = MAX_STACK_ENTRIES;
> > + trace.entries = entries;
> > + ret = save_stack_trace_tsk_reliable(task, &trace);
>
> Format the array entries before using it.

Do you mean zero the array? If so, that's not necessary because
save_stack_trace_tsk_reliable() doesn't require it. But regardless it
will automatically be zeroed because it's a static variable.

--
Josh

\
 
 \ /
  Last update: 2016-04-05 23:41    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog