Messages in this thread |  | | Date | Tue, 5 Apr 2016 16:17:06 -0500 | | From | Josh Poimboeuf <> | | Subject | Re: [RFC PATCH v1.9 12/14] livepatch: create per-task consistency model |
| |
On Wed, Apr 06, 2016 at 01:32:48AM +0800, Minfei Huang wrote: > On 03/25/16 at 02:34P, Josh Poimboeuf wrote: > > +static int klp_check_stack(struct task_struct *task) > > +{ > > + static unsigned long entries[MAX_STACK_ENTRIES]; > > + struct stack_trace trace; > > + struct klp_object *obj; > > + struct klp_func *func; > > + int ret; > > + > > + trace.skip = 0; > > + trace.nr_entries = 0; > > + trace.max_entries = MAX_STACK_ENTRIES; > > + trace.entries = entries; > > + ret = save_stack_trace_tsk_reliable(task, &trace); > > Format the array entries before using it.
Do you mean zero the array? If so, that's not necessary because save_stack_trace_tsk_reliable() doesn't require it. But regardless it will automatically be zeroed because it's a static variable.
-- Josh
|  |