lkml.org 
[lkml]   [2016]   [Apr]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v2 3/7] Improve the tracking of active utilisation
On Tue, Apr 05, 2016 at 07:56:57PM +0200, luca abeni wrote:

> > > + migrate_active = hrtimer_active(&p->dl.inactive_timer);
> > > + if (migrate_active)
> > > + sub_running_bw(&p->dl, &rq->dl);
> > > + raw_spin_unlock(&rq->lock);
> >
> > At this point task_rq() is still the above rq, so if the inactive timer
> > hits here it will lock this rq and subtract the running bw here _again_,
> > right?
> I think it will see the task state as TASK_RUNNING, so it will do nothing.
> Or it will cancelled later when the task is enqueued... I'll double check this.

Right, so this is select_task_rq_dl(), we run this in wakeups, before
TASK_RUNNING.

\
 
 \ /
  Last update: 2016-04-05 20:41    [W:0.094 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site