Messages in this thread | | | Subject | Re: [PATCH 4/7] drivers/mfd: make max14577.c explicitly non-modular | From | Javier Martinez Canillas <> | Date | Tue, 5 Apr 2016 10:24:32 -0400 |
| |
Hello Krzysztof,
On 04/03/2016 11:42 PM, Krzysztof Kozlowski wrote: > On 04.04.2016 06:24, Paul Gortmaker wrote: >> The Kconfig currently controlling compilation of this code is: >> >> mfd/Kconfig:config MFD_MAX14577 >> mfd/Kconfig: bool "Maxim Semiconductor MAX14577/77836 MUIC + Charger Support" >> >> ...meaning that it currently is not being built as a module by anyone. >> >> Lets remove the modular code that is essentially orphaned, so that >> when reading the driver there is no doubt it is builtin-only. >> >> Since module_init was not in use by this code, the init ordering >> remains unchanged with this commit. >> >> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. >> >> We also delete the MODULE_LICENSE tag etc. since all that information >> is already contained at the top of the file in the comments. >> >> Cc: Chanwoo Choi <cw00.choi@samsung.com> >> Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com> >> Cc: Samuel Ortiz <sameo@linux.intel.com> >> Cc: Lee Jones <lee.jones@linaro.org> >> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> >> --- >> drivers/mfd/max14577.c | 13 +------------ >> 1 file changed, 1 insertion(+), 12 deletions(-) > > +Cc Javier, > > In general I agree with the patchset except maybe here because it > conflicts with Javier's work to make it a module: > mfd: max14577: Use module_init() instead of subsys_initcall() > http://www.spinics.net/lists/kernel/msg2213747.html > > Javier's patchset is however missing a tested-by tag so maybe this is > why it was not merged. > > Unfortunately I cannot provide testing because my current device with > max14577/max77836 is dead and its recovery is not easy. Maybe I will get > a proper device in a few weeks after going back to Poland. > > My proposal would be to wait with this max14577 change a little bit. >
Chanwoo said he should be able to test: https://lkml.org/lkml/2016/3/18/78 So hopefully I should have some Tested-by tags for that series soon.
> Best regards, > Krzysztof >
Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America
| |