Messages in this thread | | | Date | Tue, 5 Apr 2016 10:49:15 +0300 | From | Mika Westerberg <> | Subject | Re: [RFC PATCH 3/4] pinctrl: Add ACPI support |
| |
On Mon, Apr 04, 2016 at 02:01:13PM +0000, Tirdea, Irina wrote: > > > + { > > > + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > > > + Package() > > > + { > > > + Package (2) {"pins", Package () {pin1, pin2, ...}}, > > > + Package (2) {configname1, configval1}, > > > > These should be enclosed in quotes, like "configname1" and so on. > > > OK. Should all string properties be enclosed in quotes or only the property names > (e.g. should I also change values like "configval1", "pin1", "statename1", etc.)?
I think all types should be documented using correct format. Strings should have "" and so on.
| |