lkml.org 
[lkml]   [2016]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 0/7] drivers/mfd: make max drivers explicitly non-modular
    How did you come up with the subject lines for these patches?

    Please do `git log --oneline -- <subsystem>`, as is normal when
    submitting to mainline.

    > For anyone new to the underlying goal of this cleanup, we are trying to
    > make driver code consistent with the Makefiles/Kconfigs that control them.
    >
    > This means not using modular functions/macros for drivers that can never
    > be built as a module. Some of the other downfalls this leads to are:
    >
    > (1) it is easy to accidentally write unused module_exit and remove code
    > (2) it can be misleading when reading the source, thinking it can be
    > modular when the Makefile and/or Kconfig prohibit it
    > (3) it requires the include of the module.h header file which in turn
    > includes nearly everything else, thus adding to CPP overhead.
    > (4) it gets copied/replicated into other drivers and spreads like weeds.
    >
    > There are quite a few in the mfd space, so rather than send a large
    > series, I'll try and batch them up into reasonable sized queues. To that
    > end, here we fix up all the maxim drivers as the 1st mfd batch.
    >
    > As always, the option exists for someone with the hardware and the desire
    > to extend the functionality to make any given driver tristate. But given
    > the number of these tree wide and the fact that I can't test that new
    > extended functionality in all cases, I just make the code consistent with
    > the existing Kconfig/Makefile settings that restrict them to "bool".
    >
    > Build tested on linux-next for arm, arm64 and x86-64 to ensure no typos
    > or similar issues crept in.
    >
    > Paul.
    > ---
    >
    > Cc: Chanwoo Choi <cw00.choi@samsung.com>
    > Cc: Haojian Zhuang <haojian.zhuang@marvell.com>
    > Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
    > Cc: Kyungmin Park <kyungmin.park@samsung.com>
    > Cc: Lee Jones <lee.jones@linaro.org>
    > Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
    > Cc: Samuel Ortiz <sameo@linux.intel.com>
    >
    > Paul Gortmaker (7):
    > drivers/mfd: make max8925-i2c.c explicitly non-modular
    > drivers/mfd: make max8997.c explicitly non-modular
    > drivers/mfd: make max8998.c explicitly non-modular
    > drivers/mfd: make max14577.c explicitly non-modular
    > drivers/mfd: make max77686.c explicitly non-modular
    > drivers/mfd: make max77693.c explicitly non-modular
    > drivers/mfd: make max77843.c explicitly non-modular
    >
    > drivers/mfd/max14577.c | 13 +------------
    > drivers/mfd/max77686.c | 26 ++------------------------
    > drivers/mfd/max77693.c | 34 +++-------------------------------
    > drivers/mfd/max77843.c | 24 ++----------------------
    > drivers/mfd/max8925-i2c.c | 14 +-------------
    > drivers/mfd/max8997.c | 30 +++---------------------------
    > drivers/mfd/max8998.c | 27 +--------------------------
    > 7 files changed, 13 insertions(+), 155 deletions(-)
    >

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog

    \
     
     \ /
      Last update: 2016-04-04 11:02    [W:2.664 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site