lkml.org 
[lkml]   [2016]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mtd: gpmi: fix raw_buffer pointer double free issue
From
Date
Am 04.04.2016 um 19:25 schrieb Han Xu:
> fix the raw_buffer pointer double free issue found by coverify.

Can you please include the coverity message in you changelog?

> Signed-off-by: Han Xu <han.xu@nxp.com>
> ---
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 8122c69..dcb60b0 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -797,6 +797,7 @@ static void gpmi_free_dma_buffer(struct gpmi_nand_data *this)
>
> this->cmd_buffer = NULL;
> this->data_buffer_dma = NULL;
> + this->raw_buffer = NULL;
> this->page_buffer_virt = NULL;
> this->page_buffer_size = 0;

So, gpmi_free_dma_buffer() is called twice and therefore we need to NULL all
these pointers?

Thanks,
//richard

\
 
 \ /
  Last update: 2016-04-04 20:41    [W:0.030 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site