lkml.org 
[lkml]   [2016]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue
    From
    Hi Rob,

    2016-03-22 17:11 GMT+01:00 Alexandre Torgue <alexandre.torgue@gmail.com>:
    > Hi guys,
    >
    > I will fix typo issues (s/vesrion/version and ethernet @).
    >
    > Concerning compatible string. For sure "snps,dwmac-3.50a" string is
    > not used inside glue driver.
    > I perfere to keep it for information but if you really want that I
    > remove it I will not block ;)
    >
    > 2016-03-21 16:36 GMT+01:00 Joachim Eastwood <manabian@gmail.com>:
    >> On 21 March 2016 at 13:40, Rob Herring <robh@kernel.org> wrote:
    >>> On Sat, Mar 19, 2016 at 12:00:22AM +0800, Chen-Yu Tsai wrote:
    >>>> Hi,
    >>>>
    >>>> On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE
    >>>> <alexandre.torgue@gmail.com> wrote:
    >>>> > +- clocks: Must contain a phandle for each entry in clock-names.
    >>>> > +- clock-names: Should be "stmmaceth" for the host clock.
    >>>
    > We can remove host clock (stmmac eth) entry here and refer to
    > stmmac.txt binding for common entry
    >
    >>> This doesn't sound like the clock input signal name...
    >>>
    >>>> > + Should be "tx-clk" for the MAC TX clock.
    >>>> > + Should be "rx-clk" for the MAC RX clock.
    >>>
    >>> How can other DWMAC blocks not have these clocks? The glue can't really
    >>> add these clocks. It could combine them into one or a new version of
    >>> DWMAC could have a different number of clock inputs. So if there is
    >>> variation here, then some of the bindings are probably wrong. I guess
    >>> the only change I'm suggesting is possibly moving these into common
    >>> binding doc.
    >>
    >> The LPC18xx implementation probably have these clocks as well but the
    >> LPC1850 user manual only documents the main clock. Someone with access
    >> to the IP block doc from Synopsys should be able to check which clocks
    >> the MAC really needs.
    >>
    >> Rockchip bindings have two clocks named "mac_clk_rx" and "mac_clk_tx".
    >> These are probably the same as stm32 needs so maybe use these names
    >> and move them into the main doc and update the rockchip binding.
    >>
    > I think we can use same name. But I have a doubt on moving it in a
    > common bindings (maybe I don't well understood). When you say "common
    > binding file" is it "stmmac.txt" binding ? If yes does it mean that we
    > have to control it inside stmmac driver (no more in glue) ? In this
    > case those clocks will become "required" for stm32 and rockship but
    > not for others chip. It could create confusion?

    A gentle ping. Can you give me your feedback please ?
    I will send next patchset version according to your answer.

    Thanks in advance

    Alex

    >
    > Best regards
    >
    > Alex
    >
    >>
    >> regards,
    >> Joachim Eastwood

    \
     
     \ /
      Last update: 2016-04-04 17:01    [W:4.108 / U:1.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site