lkml.org 
[lkml]   [2016]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 1/8] lib/vsprintf: simplify UUID printing
    Date
    Since we have hex_byte_pack_upper() we may use it directly and avoid second
    loop.

    Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    ---
    lib/vsprintf.c | 12 ++++--------
    1 file changed, 4 insertions(+), 8 deletions(-)

    diff --git a/lib/vsprintf.c b/lib/vsprintf.c
    index ccb664b..be0e7cf 100644
    --- a/lib/vsprintf.c
    +++ b/lib/vsprintf.c
    @@ -1324,7 +1324,10 @@ char *uuid_string(char *buf, char *end, const u8 *addr,
    }

    for (i = 0; i < 16; i++) {
    - p = hex_byte_pack(p, addr[index[i]]);
    + if (uc)
    + p = hex_byte_pack_upper(p, addr[index[i]]);
    + else
    + p = hex_byte_pack(p, addr[index[i]]);
    switch (i) {
    case 3:
    case 5:
    @@ -1337,13 +1340,6 @@ char *uuid_string(char *buf, char *end, const u8 *addr,

    *p = 0;

    - if (uc) {
    - p = uuid;
    - do {
    - *p = toupper(*p);
    - } while (*(++p));
    - }
    -
    return string(buf, end, uuid, spec);
    }

    --
    2.8.0.rc3
    \
     
     \ /
      Last update: 2016-04-04 16:01    [W:3.192 / U:1.440 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site