Messages in this thread Patch in this message | | | From | Ming Lei <> | Subject | [PATCH v2 3/8] block: mark 1st parameter of bvec_iter_advance as const | Date | Mon, 4 Apr 2016 00:31:04 +0800 |
| |
bvec_iter_advance() only writes the parameter of iterator, so the base address of bvec can be marked as const safely.
Without the change, we can see compiling warning in the following patch for implementing iterate_bvec(): lib/iov_iter.c with bvec iterator.
Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Ming Lei <ming.lei@canonical.com> --- include/linux/bvec.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/linux/bvec.h b/include/linux/bvec.h index e111124..0c6fa42 100644 --- a/include/linux/bvec.h +++ b/include/linux/bvec.h @@ -63,7 +63,8 @@ struct bvec_iter { .bv_offset = bvec_iter_offset((bvec), (iter)), \ }) -static inline void bvec_iter_advance(struct bio_vec *bv, struct bvec_iter *iter, +static inline void bvec_iter_advance(const struct bio_vec *bv, + struct bvec_iter *iter, unsigned bytes) { WARN_ONCE(bytes > iter->bi_size, -- 1.9.1
| |