lkml.org 
[lkml]   [2016]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 03/11] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback
    From
    Date
    On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote:
    > Documentation/serial/driver clearly states:
    >
    > If the port does not support CTS, DCD or DSR, the driver should
    > indicate that the signal is permanently active.
    >
    > Hence always set TIOCM_CTS, as we currently don't look at the CTS
    > hardware line state at all.
    >
    > FWIW, this fixes the transmit path when hardware-assisted flow control
    > is enabled, and userspace enables CRTSCTS.
    > The receive path is still broken, as RTS is never asserted.

    Reviewed-by: Peter Hurley <peter@hurleysoftware.com>

    \
     
     \ /
      Last update: 2016-04-29 18:01    [W:2.967 / U:0.296 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site