Messages in this thread | | | Subject | Re: [PATCH v2 03/11] serial: sh-sci: Always set TIOCM_CTS in .get_mctrl() callback | From | Peter Hurley <> | Date | Fri, 29 Apr 2016 08:38:09 -0700 |
| |
On 04/29/2016 05:58 AM, Geert Uytterhoeven wrote: > Documentation/serial/driver clearly states: > > If the port does not support CTS, DCD or DSR, the driver should > indicate that the signal is permanently active. > > Hence always set TIOCM_CTS, as we currently don't look at the CTS > hardware line state at all. > > FWIW, this fixes the transmit path when hardware-assisted flow control > is enabled, and userspace enables CRTSCTS. > The receive path is still broken, as RTS is never asserted.
Reviewed-by: Peter Hurley <peter@hurleysoftware.com>
| |