lkml.org 
[lkml]   [2016]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] efi: Remove unnecessary (and buggy) .memmap initialization from the Xen EFI driver
On Fri, 29 Apr, at 10:31:28AM, Ingo Molnar wrote:
>
> So this commit triggered the follwing build warning on x86 64-bit allyesconfig:

Doh! I wonder why the 0day bot didn't tell me about this?

> It's this initialization in drivers/xen/efi.c:
>
> static const struct efi efi_xen __initconst = {
> ...
> .memmap = NULL, /* Not used under Xen. */
> ...
>
> which was forgotten about, as .memmap now is an embedded struct:
>
> struct efi_memory_map memmap;
>
> We can remove this initialization - it's an EFI core internal data structure plus
> it's not used in the Xen driver anyway.
>
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
> drivers/xen/efi.c | 1 -
> 1 file changed, 1 deletion(-)

Yep, looks good. Thanks Ingo!

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

\
 
 \ /
  Last update: 2016-04-29 11:01    [W:0.063 / U:53.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site