lkml.org 
[lkml]   [2016]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] tty: serial: msm_serial add info message
On 4/28/2016 1:51 PM, Greg Kroah-Hartman wrote:
> On Sat, Apr 23, 2016 at 10:17:05AM -0700, Frank Rowand wrote:
>> From: Frank Rowand <frank.rowand@am.sony.com>
>>
>> Failure to enable DMA by the msm_serial driver is silent.
>> Add a message to report the failure.
>>
>> Signed-off-by: Frank Rowand <frank.rowand@am.sony.com>
>> ---
>> drivers/tty/serial/msm_serial.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> Index: b/drivers/tty/serial/msm_serial.c
>> ===================================================================
>> --- a/drivers/tty/serial/msm_serial.c
>> +++ b/drivers/tty/serial/msm_serial.c
>> @@ -170,6 +170,7 @@ rel_tx:
>> dma_release_channel(dma->chan);
>> no_tx:
>> memset(dma, 0, sizeof(*dma));
>> + dev_info(dev, "msm_serial: DMA not enabled\n");
>
> Don't print out messages that a user can't do something with :(
>
> So I agree, this is not needed, sorry.
>
> greg k-h
>

I am ok with dropping patch 2. No problem.

-Frank

\
 
 \ /
  Last update: 2016-04-29 00:41    [W:0.089 / U:0.728 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site