Messages in this thread | | | Date | Thu, 28 Apr 2016 18:00:21 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH 19/20] md: simplify free_params for kmalloc vs vmalloc fallback |
| |
On Thu 28-04-16 11:37:31, Mike Snitzer wrote: > On Thu, Apr 28 2016 at 9:24am -0400, > Michal Hocko <mhocko@kernel.org> wrote: > > > From: Michal Hocko <mhocko@suse.com> > > > > Use kvfree rather than DM_PARAMS_[KV]MALLOC specific param flags. > > > > Cc: Shaohua Li <shli@kernel.org> > > Cc: Mikulas Patocka <mpatocka@redhat.com> > > Cc: dm-devel@redhat.com > > Signed-off-by: Michal Hocko <mhocko@suse.com> > > Nack, seriously, this is the 3rd time this patch has been attempted. > Did you actually test the change? It'll crash very quickly, see: > > https://www.redhat.com/archives/dm-devel/2016-April/msg00103.html
You are right! My bad I should have checked the other callers!
-- Michal Hocko SUSE Labs
| |