lkml.org 
[lkml]   [2016]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 1/2] mm, kasan: don't call kasan_krealloc() from ksize().
From
On Fri, Apr 22, 2016 at 11:32 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> On Wed, 13 Apr 2016 13:20:09 +0200 Alexander Potapenko <glider@google.com> wrote:
>
>> Instead of calling kasan_krealloc(), which replaces the memory allocation
>> stack ID (if stack depot is used), just unpoison the whole memory chunk.
>
> I don't understand why these two patches exist. Bugfix? Cleanup?
> Optimization?
It's incorrect to call kasan_krealloc() from ksize(), because the
former may touch the allocation metadata (it does so for the SLAB
allocator).
Yes, this is a bugfix.
>
> I had to change kmalloc_tests_init() a bit due to
> mm-kasan-initial-memory-quarantine-implementation.patch:
>
> kasan_stack_oob();
> kasan_global_oob();
> #ifdef CONFIG_SLAB
> kasan_quarantine_cache();
> #endif
> + ksize_unpoisons_memory();
> return -EAGAIN;
> }
>
> Please check.
Ack.



--
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

\
 
 \ /
  Last update: 2016-04-28 14:01    [W:0.051 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site